[PM-14243] Free organization limit is not enforced when editing user #5155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…free organizations
…s to sign up for another free organization
…nforced-when-editing-user
r-tome
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5155 +/- ##
==========================================
+ Coverage 44.07% 44.09% +0.01%
==========================================
Files 1476 1476
Lines 68260 68270 +10
Branches 6178 6181 +3
==========================================
+ Hits 30089 30106 +17
+ Misses 36864 36854 -10
- Partials 1307 1310 +3 ☔ View full report in Codecov by Sentry. |
|
Fixed Issues (4)Great job! The following issues were fixed in this Pull Request
|
BTreston
previously approved these changes
Dec 18, 2024
BTreston
approved these changes
Jan 13, 2025
…nforced-when-editing-user
…nforced-when-editing-user
…nforced-when-editing-user
r-tome
deleted the
ac/pm-14243/free-organization-limit-is-not-enforced-when-editing-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14243
📔 Objective
Enforce the free organization limit when editing a user. Add unit tests to verify this enforcement during organization creation and member acceptance flows.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes